Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart case is not as smart as ripgrep's #103

Closed
jakwings opened this issue Oct 12, 2017 · 2 comments
Closed

Smart case is not as smart as ripgrep's #103

jakwings opened this issue Oct 12, 2017 · 2 comments
Labels
feature-request
Milestone
v5.0

Comments

@jakwings
Copy link
Contributor

Although I'm not a fan of this feature, you may be interested.

Example: \Acargo and carg\x6F do not match "Cargo".

ripgrep uses the regex-syntax crate to check the regex AST.
@sharkdp
Copy link
Owner

sharkdp commented Oct 12, 2017

Thank you for reporting this!

@reima
Copy link
Contributor

reima commented Oct 13, 2017

I'll take a look at this!

@reima reima mentioned this issue Oct 13, 2017
Merged
sharkdp pushed a commit that referenced this issue Oct 14, 2017
@reima @sharkdp
Improve smart case to only consider literal uppercase chars (#103)
b441528
@sharkdp sharkdp added this to the v5.0 milestone Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
v5.0
Development

No branches or pull requests
3 participants
@reima @sharkdp @jakwings