Replace dirs-next crate with etcetera crate

[utkarshgupta137]

The config path is unchanged. The etcetera crate allows you to use the XDG spec on macOS too without any hassle. In addition, it is slightly smaller.

[tmccombs]

Would it be better to do something like:

if let Ok(appdirs) = etcetera::choose_app_strategy(etcetera::AppStrategyArgs {
    top_level_domain: "io.github".to_string(),
    author: "sharkdp".to_string(),
    app_name: "fd".to_string(),
}) {
    let global_ignore_file = appdirs.config_dir().join("ignore");

although, I think that would change the location on windows.

[utkarshgupta137]

Yes, it would.

[tmccombs]

I think the behaviro on windows is a little different. etcetera just joins "AppData\Roaming" to the users home directory, but dirs_next calls shlobj::SHGetKnownFolderPath. I'm not entirely sure how things work in windows, but https://learn.microsoft.com/en-us/windows/win32/shell/knownfolderid says that that is the "Default Path" for the RoamingAppData folder. which makes me think it is possible it could be something else.

[utkarshgupta137]

I think the behaviro on windows is a little different. etcetera just joins "AppData\Roaming" to the users home directory, but dirs_next calls shlobj::SHGetKnownFolderPath. I'm not entirely sure how things work in windows, but https://learn.microsoft.com/en-us/windows/win32/shell/knownfolderid says that that is the "Default Path" for the RoamingAppData folder. which makes me think it is possible it could be something else.

I've created a PR for etcetera. I'll wait for a review, then merge it & release a new version.

[utkarshgupta137]

I think the behaviro on windows is a little different. etcetera just joins "AppData\Roaming" to the users home directory, but dirs_next calls shlobj::SHGetKnownFolderPath. I'm not entirely sure how things work in windows, but https://learn.microsoft.com/en-us/windows/win32/shell/knownfolderid says that that is the "Default Path" for the RoamingAppData folder. which makes me think it is possible it could be something else.

This is addressed in etcetera v0.8

[sharkdp]

Thank you. If I understand correctly, there is no change for our users, so we don't really need a CHANGELOG entry for this? If this is not the case, it would be great if you could open a quick PR with a CHANGELOG entry.

[utkarshgupta137]

Thank you. If I understand correctly, there is no change for our users, so we don't really need a CHANGELOG entry for this? If this is not the case, it would be great if you could open a quick PR with a CHANGELOG entry.

No, no user-facing changes are expected. Same for the PRs for bat & vivid.