Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dirs crate with etcetera crate #2548

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

utkarshgupta137
Copy link
Contributor

The cache & config paths are unchanged. The etcetera crate allows you to use the XDG spec on macOS too without any hassle. In addition, it is slightly smaller.

Disclaimer: I've recently become a maintainer of the etcetera crate. AFAIK, it is the only crate that can replace this logic.

@eth-p eth-p added the dependencies Pull requests that update a dependency file label Apr 22, 2023
@eth-p
Copy link
Collaborator

eth-p commented Apr 22, 2023

Thanks for the contribution!

@(the other maintainers):
I can confirm it works as intended for me on MacOS :)
And compiled with --release, it's about 49000 bytes smaller on aarch64, too.

@utkarshgupta137
Copy link
Contributor Author

@sharkdp This is the same PR as sharkdp/fd#1304 & sharkdp/vivid#103

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'm okay with this change but it needs a rebase. Sorry for the delay in reviewing.

@sharkdp sharkdp merged commit 3abc0c0 into sharkdp:master Sep 1, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants