Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shell completions OUT_DIR #169

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Conversation

andoriyu
Copy link
Contributor

@andoriyu andoriyu commented Nov 15, 2017

Right now it panics with OUT_DIR is not exist prior compilation. Which is not nice.

@sharkdp sharkdp merged commit 3104729 into sharkdp:master Nov 15, 2017
@sharkdp
Copy link
Owner

sharkdp commented Nov 15, 2017

Thank you very much!

@andoriyu
Copy link
Contributor Author

Are you only tagging major releases? I've noticed crate version on crates is 5.0.1, but last tag is 5.0.0.

@sharkdp
Copy link
Owner

sharkdp commented Nov 15, 2017

5.0.1 was an unfortunate mistake from my side 😄 It's functionally equivalent to 5.0.0 but I had to adapt something for crates.io. I didn't want to tag it in Git because it would have triggered a completely new build with new binaries etc.

Shouldn't happen in the future.. usually all releases will be tagged. Thanks for asking.

@andoriyu andoriyu deleted the patch-1 branch November 15, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants