fd --exec should fail if one of --exec fails #526 #531
Conversation
fusillicode
changed the title
src/exit_codes.rs
Outdated
|
|
||
| impl ExitCode { | ||
| pub fn error_if_any_error(results: Vec<Self>) -> Self { | ||
| if results.iter().any(|s| match s { |
There was a problem hiding this comment.
Maybe this match should be extracted into another function: ExitCode::is_error?
There was a problem hiding this comment.
This way, we could simply run: if results.iter().any(ExitCode::is_error) { … }
src/exit_codes.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| impl ExitCode { | ||
| pub fn error_if_any_error(results: Vec<Self>) -> Self { |
There was a problem hiding this comment.
It feels a little strange to me to have this in an impl ExitCode block. I think it could easily be a free function.
As for the naming, maybe: merge_exitcodes?
Finally: can we please add a few unit tests for this function (in this file)?
There was a problem hiding this comment.
I think I've added a few interesting unit tests of merge_exitcodes.
Let us know if they're good enough 😄
Thank you! |
|
Hi 😄 I've checked all your comments and suggestions and I'll follow them as soon as possible. I hope to be able to polish this PR before the next monthly meeting of the Open Source Saturday but unfortunately I can't promise that (I wish I could 😞) |
Hey, no worries. There's absolutely no time pressure here. We'll merge it whenever it's ready. Thank you! |
|
♾ 🙇 |
fusillicode
force-pushed
the
issue-526
branch
from
ef58741
to
0ef6ecc
Compare
|
I think I've addressed pretty much everything that was pointed out last month 🤔 I remain obviously at your total disposal for every new comments 😄 |
|
@sharkdp thank you once again for all your invaluable work & support! 🙇♂️ We really hope to be able to further contribute to your projects! 😄 Cheers! |
|
Looking forward to it! |
Me and @Giuffre tried to tackle this issue during our monthly OSS meeting 😄:
We apologize in advance if we didn't properly addressed what stated in the over mentioned issue and we remain at disposal to further work on it during our next meeting 🙇
P.S: thank you a lot for this wonderful crate! 🙇♂️