Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nuget for MVC 4 references #106

Merged
merged 2 commits into from
Aug 17, 2014
Merged

Use nuget for MVC 4 references #106

merged 2 commits into from
Aug 17, 2014

Conversation

kabudahab
Copy link

No description provided.

@@ -15,12 +15,12 @@
<dependencies>
<dependency id="Castle.Core" version="[3.2,4.0)" />
<dependency id="Castle.Windsor" version="[3.2,4.0)" />
<dependency id="CommonServiceLocator.WindsorAdapter" version="1.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this was removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package CommonServiceLocator.WindsorAdapter is not referenced by the SharpArch.Web.Mvc.Castle project (https://github.com/sharparchitecture/Sharp-Architecture/blob/master/Solutions/SharpArch.Web.Mvc/packages.config).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but the spec generates the package for consumers. If the Windsor adapter is not in the spec then the template won't and people would have to manually add it.Can you add it please

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I'll test it and publish to nuget hopefully this week.

Apologies in advance for any auto correction or spelling mistakes, sent
from my phone.
On 16 Aug 2014 15:07, "kad0xf" notifications@github.com wrote:

In NugetTemplates/SharpArch.Web.Mvc.Castle/SharpArch.Web.Mvc.Castle.nuspec:

@@ -15,12 +15,12 @@


  •  <dependency id="CommonServiceLocator.WindsorAdapter" version="1.0" />
    

Added.


Reply to this email directly or view it on GitHub
https://github.com/sharparchitecture/Sharp-Architecture/pull/106/files#r16324910
.

@seif seif merged commit a0d06f4 into sharparchitecture:master Aug 17, 2014
@seif
Copy link
Member

seif commented Aug 17, 2014

Thanks @kad0xf I have just pushed a 2.2 release candidate to nuget, need to update the templates and contrib project before proper release.

Probably next weekend.

@seif
Copy link
Member

seif commented Aug 17, 2014

Probably next weekend :)

@kabudahab kabudahab deleted the Use-nuget-for-MVC-4-references branch August 18, 2014 07:15
@kabudahab
Copy link
Author

@seif When will version 2.2 be released?

@seif
Copy link
Member

seif commented Feb 5, 2015

I never got around to testing the RC, have you used? No problems? I can
probably push it out tonight

Apologies in advance for any auto correction or spelling mistakes, sent
from my phone.
On 5 Feb 2015 09:46, "kad0xf" notifications@github.com wrote:

@seif https://github.com/seif When will version 2.2 be released fully?


Reply to this email directly or view it on GitHub
#106 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants