Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadSetting CacheControl is not setting #20

Closed
Jeff-Stapleton opened this issue Aug 16, 2018 · 2 comments
Closed

UploadSetting CacheControl is not setting #20

Jeff-Stapleton opened this issue Aug 16, 2018 · 2 comments

Comments

@Jeff-Stapleton
Copy link

I am trying the set CacheControl to "no-cache" but no matter what I do CacheControl always reverts to "public, max-age=864000"

var settings = CreateSyncSettings(awsAccessKey, awsSecretKey)
            .SetBucketName(s3Bucket)
            .SetRegion(regionName)
            .SetLowerPaths(false);
        
settings.CacheControl = "no-cache";

var invalidationList = await S3SyncUpload((DirectoryPath)"site", settings);
@SharpeRAD
Copy link
Owner

Hi Jeff, can you check which version of Cake.AWS.S3 your using as I fixed this in v0.6.5. S3SyncUpload is now setting a custom Cache-Control header for our CDN 😄

Please close the issue if upgrading resolves this for you.

@Jeff-Stapleton
Copy link
Author

That did the trick! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants