AWS environment variables and fallback credentials

[gitfool]

This is a very useful addin for Cake, thanks! 😉

One problem I hit was that the AWS environment variables used by CakeEnvironmentExtensions don't match what's used by the AWS SDK:

• CakeEnvironmentExtensions.cs#L31
• AWSCredentials.cs#L649

Was this a deliberate choice to differentiate them from the fallback credentials used by the SDK?

Normally I use the ctors which leverage the FallbackCredentialsFactory:

• AmazonS3Client.cs#L60
• AmazonS3Client.cs#L79

... which gives you a few ways to automatically inject the credentials - via an instance profile when running inside AWS or via the standard environment variables when running outside AWS.

Not a major problem obviously, but it does require more setup than expected for the common case, so this addin should ideally use the same standard conventions already established by the AWS SDK.

[SharpeRAD]

Sorry for the delay in replying I was out of the country with limited access to the internet. I can't argue with your logic so I've updated all of my AWS addins to use the SDK naming convention 😄

[gitfool]

Thanks @SharpeRAD.

FWIW, here is FallbackCredentialsFactory which has more flexible options for specifying AWS credentials, including via environment variables or instance profiles, the latter of which is the recommended approach when running from inside AWS. I don't need this right now, but I'm sure others will be doing builds on EC2 instances...

In order to leverage this you'd need to use the other ctors for any Amazon clients, although I just noticed that FallbackCredentialsFactory is public, so another way might be to call FallbackCredentialsFactory.GetCredentials() directly if you need more control?