Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String.format over string.replace #2

Closed
Cethric opened this issue Dec 20, 2015 · 1 comment
Closed

String.format over string.replace #2

Cethric opened this issue Dec 20, 2015 · 1 comment

Comments

@Cethric
Copy link
Contributor

Cethric commented Dec 20, 2015

In the creation of an element use str.format over str.replace
As this will only require one call to the string instead of multiple calls
This is mainly for line 47 onwards of ElementManager.py
Useful information
https://pyformat.info/

EDIT
Ignore this I am creating a pull request for this issue. (Along with fixing a few other things)
@Cethric Cethric closed this as completed Dec 20, 2015
@shaun-h
Copy link
Owner

shaun-h commented Dec 21, 2015

no problems I will take a look at the pull requests soon, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaun-h @Cethric