Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tests are atrociously inefficient and disorganized #110

Closed
ressy opened this issue Dec 9, 2020 · 0 comments · Fixed by #111
Closed

The tests are atrociously inefficient and disorganized #110

ressy opened this issue Dec 9, 2020 · 0 comments · Fixed by #111

Comments

@ressy
Copy link
Member

ressy commented Dec 9, 2020

Running python -m unittest currently takes several minutes to complete locally and upwards of 30 minutes on CircleCI which is kind of absurd. The tests should be disentangled from one another, superfluous subclasses cleaned up, and mock objects used wherever appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor unit tests and migrate to CircleCI ShawHahnLab/umbra
1 participant
@ressy