Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required feature incorrect #2

Open
codepathreview opened this issue Oct 31, 2016 · 1 comment
Open

Required feature incorrect #2

codepathreview opened this issue Oct 31, 2016 · 1 comment

Comments

@codepathreview
Copy link

@ShawnDuan it seems from your code that you do not immediately add the newly composed tweet to the timeline, on successfully posting it to Twitter, but instead rely on timeline refresh which might not always be reliable.

See the below hint which can be found here https://courses.codepath.com/courses/intro_to_android/unit/3#!hints
Note #1: Make sure that after you compose a tweet that the new tweet shows up in the timeline. To do this, refreshing the timeline may not be enough because of the lag before the new tweet shows up in the timeline API call. Instead, after the tweet is successfully posted to twitter from within the compose screen, we can pass the Tweet back to the TimelineActivity through the intent result system to the parent activity and inject the created tweet directly into the adapter for the timeline from within onActivityResult. See the intents cliffnotes for how to return the result back to the timeline activity.

Fix accordingly and resubmit

@ShawnDuan
Copy link
Owner

Resubmitted, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants