New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in DataReader.py when loading vocab from dialogues #7

Open

garygsw opened this issue Sep 4, 2018 · 0 comments

garygsw commented Sep 4, 2018

Hi, I would like to clarify if this is a bug.

NNDIAL/loader/DataReader.py

Lines 876 to 880 in 740f6d3

    
           # user side 
        
           words = self.delexicalise(turn['usr']['transcript']).split() 
        
           mwords,words,_,_,_ = self.extractSeq(turn['sys']['sent'],\ 
        
               type='source',index=False) 
        
           ivocab.extend(mwords)

Should the extractSeq method in line 878 be called on turn['usr']['transcript'] instead?

The words variable in line 877 is totally ignored, and replaced by the return values of extractSeq in line 878.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment