Setting assert_hostname to False will disable SSL hostname verification #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Figovsky <boris.figovsky@ravellosystems.com>
|
This looks good. Doesn't affect the existing API, and only modifies one line. (Should probably close all the other pull requests.) |
|
Looks really nice 👍 |
shazow
added a commit
that referenced
this pull request
Jun 6, 2013
Setting assert_hostname to False will disable SSL hostname verification.
|
Thanks for sticking through it, Boris! :) |
|
You are welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the use of
assert_hostname=Falseto disable SSL hostname verification.