Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add stateMutability #17

Closed
KingMaxime opened this issue Dec 3, 2022 · 5 comments
Closed

feature: Add stateMutability #17

KingMaxime opened this issue Dec 3, 2022 · 5 comments
Labels
soon Planned, targeting a near-future release

Comments

@KingMaxime
Copy link

KingMaxime commented Dec 3, 2022 •
edited
Loading

is there any way to get the stateMutability of a function whether it is view or nonpayable just like in standard abi?
@shazow
Copy link
Owner

shazow commented Dec 3, 2022

Yup, coming up next release! I have some WIP in #14 if you want to sub to that. Just need to push the stateMutability improvements shortly.

@shazow shazow added the soon Planned, targeting a near-future release label Dec 3, 2022
@KingMaxime
Copy link
Author

Okay nice. 👍 Great Job with this package save me a lot of work

Yup, coming up next release! I have some WIP in #14 if you want to sub to that. Just need to push the stateMutability improvements shortly.

@shazow
Copy link
Owner

shazow commented Jan 22, 2023 •
edited
Loading

Just merged #14 into master, would appreciate some testing/feedback before I do a release. There's some major changes:

In some cases, it manages to successfully guess whether there are inputs or outputs (not super reliable, I'd say like... 60%?), but there have been major changes behind the scenes with how the static analysis works so we can do more advanced things moving forward.

Also we now have stateMutability included in the ABI, which is reliable in detecting payable functions, but not reliable in distinguishing nonpayable vs view yet (no attemps to detect pure yet, probably too dangerous to be wrong?).

@shazow
Copy link
Owner

shazow commented Jan 22, 2023

Next release issue is here: #18

@shazow shazow mentioned this issue Jan 22, 2023
Closed
4 tasks
@shazow
Copy link
Owner

shazow commented Jan 31, 2023

Included in the latest release: https://github.com/shazow/whatsabi/releases

@shazow shazow closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soon Planned, targeting a near-future release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shazow @KingMaxime