-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostnames and RouteCollectionExtensions.cs YSOD #11
Comments
Same issue here. Will try to change the ArticulateRoutes and see what will happen. |
Same issue here, the problem is indeed that the node.Url starts with http://hostname |
I think I've just solved this in PR #22 |
Seems like that fixed it ;) nice work! |
Hrm, it only masked the problem... That fix will cause problems with multiple articulate roots with domains as you'll get routed to the first articulate root for all other ones. I'll see what i can do. |
Ah yes, this fixes for a single Articulate in a Umbraco install but for multiple Articulate instances in a Umbraco install it's not going to work (unless they have different root node urls) |
Yup, fixing now, it's a multi-tenancy issue which i never thought of.. the fix is kind of interesting though, never had to do this before :) |
Ok all fixed, multi-tenancy is all working now, will release a new version soon :) |
Hi @Shandem - when will this be included in a Release? I've installed Articulate to try it out but getting the YSOD with this error |
When I have time :) hopefully next week |
OK cheers Shannon |
I am having this issue now. I did not realise it was an issue and created a second Articulate blog under the Home page. I now cannot get my Umbraco site running at all and cannot get into it to remove the offending node. I have deleted the latest 5 cmsDocument nodes from the database but am now out of options. |
Running articulate on a site with hostnames defined, will cause problems (e.g. www.myurl.eu):
YSOD:
Parameter name: routeUrl
The parameter url being passed is:
This could be avoided by using
node.UrlName
instead ofnode.Url
in ArticulateRoutes.cs, unless of course that could case issues in other cases. In which case url could probably be cleaned up with a regex or something.The text was updated successfully, but these errors were encountered: