Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostnames and RouteCollectionExtensions.cs YSOD #11

Closed
KrisJanssen opened this issue Jul 22, 2014 · 12 comments
Closed

Hostnames and RouteCollectionExtensions.cs YSOD #11

KrisJanssen opened this issue Jul 22, 2014 · 12 comments
Assignees
Labels

Comments

@KrisJanssen
Copy link

Running articulate on a site with hostnames defined, will cause problems (e.g. www.myurl.eu):

YSOD:

The route URL separator character '/' cannot appear consecutively. It must be separated by either a parameter or a literal value.

Parameter name: routeUrl

Line 11: object constraints = null, string[] namespaces = null)
Line 12:   {
Line 13:      var route = RouteTable.Routes.MapRoute(name, url, defaults, constraints,    namespaces);
Line 14:      route.RouteHandler = virtualNodeHandler;
Line 15:      return route;

Source File: c:\Users\kris\Documents\Articulate\Articulate\RouteCollectionExtensions.cs    Line: 13 

The parameter url being passed is:

"http://www.myurl.eu/blog/rss"

This could be avoided by using node.UrlName instead of node.Url in ArticulateRoutes.cs, unless of course that could case issues in other cases. In which case url could probably be cleaned up with a regex or something.

@Mantus667
Copy link

Same issue here. Will try to change the ArticulateRoutes and see what will happen.
Happens not only with the RSS url but with all.

@Eyescream
Copy link

Same issue here, the problem is indeed that the node.Url starts with http://hostname

@Shazwazza Shazwazza self-assigned this Sep 5, 2014
@Shazwazza Shazwazza added the bug label Sep 5, 2014
@Jeavon
Copy link
Contributor

Jeavon commented Sep 24, 2014

I think I've just solved this in PR #22

@Shazwazza
Copy link
Owner

Seems like that fixed it ;) nice work!

@Shazwazza
Copy link
Owner

Hrm, it only masked the problem... That fix will cause problems with multiple articulate roots with domains as you'll get routed to the first articulate root for all other ones. I'll see what i can do.

@Shazwazza Shazwazza reopened this Sep 26, 2014
@Jeavon
Copy link
Contributor

Jeavon commented Sep 26, 2014

Ah yes, this fixes for a single Articulate in a Umbraco install but for multiple Articulate instances in a Umbraco install it's not going to work (unless they have different root node urls)

@Shazwazza
Copy link
Owner

Yup, fixing now, it's a multi-tenancy issue which i never thought of.. the fix is kind of interesting though, never had to do this before :)

@Shazwazza
Copy link
Owner

Ok all fixed, multi-tenancy is all working now, will release a new version soon :)

@dannykpowell
Copy link

Hi @Shandem - when will this be included in a Release? I've installed Articulate to try it out but getting the YSOD with this error

@Shazwazza
Copy link
Owner

When I have time :) hopefully next week

@dannykpowell
Copy link

OK cheers Shannon

@FootswordTechnologies
Copy link

I am having this issue now. I did not realise it was an issue and created a second Articulate blog under the Home page. I now cannot get my Umbraco site running at all and cannot get into it to remove the offending node. I have deleted the latest 5 cmsDocument nodes from the database but am now out of options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants