[Bug]: User are displayed only with first name and lower capital letters

[jurrejansen]

Contact Details

No response

What happened?

Custodian badges are not showing full name of user when asset status is In custody.

What is the expected behaviour?

The users should be displayed with both First name and Last name

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Safari

Relevant log output

No response

[carlosvirreira]

ty for reporting @jurrejansen

[DonKoko]

@jurrejansen I cannot re-create either the dropdown nor the table issue. Please invite me to the workspace where this happens so I can check it out in detail. I have a suspicion what the reason could be but I need more info so I can search for it in the DB.
Thanks for reporting.

[jurrejansen]

Hi @DonKoko I am now experiencing blank menu items when checking out. Down below are 2 screenrecordings both recorded on the app.shelf. In the demo workspace it seems that the user that is appearing is blank is your user that was invited to investigate this issue.

https://github.com/Shelf-nu/shelf.nu/assets/76112272/ccea5e02-d872-43c3-a1ac-474e9061300f
https://github.com/Shelf-nu/shelf.nu/assets/76112272/4e07f38f-e9d6-433a-97de-33ac52ba7c33

[DonKoko]

@jurrejansen @carlosvirreira released a fix to live with lots of improvements.
This issue opened a can of worms but ended up being amazing improvement. Please re-open if you notice any issues.

[DonKoko]

OKey we still have some places that need adjustment, namely Notes:

[DonKoko]

@carlosvirreira this has been resolved. I had missed a few places. Also fixing this helped us find some other bugs related to NRM and bookings and custodians. Those are fixed as well.