Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index category filtering #70

Closed
5 of 6 tasks
DonKoko opened this issue Apr 7, 2023 · 8 comments
Closed
5 of 6 tasks

Index category filtering #70

DonKoko opened this issue Apr 7, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@DonKoko
Copy link
Contributor

DonKoko commented Apr 7, 2023

Adding the category filtering to the index. Its basically working but we still have quite some things to handle:

  • Search is somehow broken right now. If you try to search it refreshes the page
  • Empty state for categories filter(if no categories)
  • Merge params of prev,next,search and page numbers with categories params(maybe make it so that categories filter and search are part of the same form.
  • Double check for hydration issues due to client side only components
  • Clear categories filter ( Dont have design for this so I will wing it)
  • Fallback states for clientOnly components(category select and categories filter dropdown)
@DonKoko DonKoko added the enhancement New feature or request label Apr 7, 2023
@DonKoko DonKoko self-assigned this Apr 7, 2023
@DonKoko DonKoko pinned this issue Apr 7, 2023
@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 10, 2023

@jurrejansen @carlosvirreira this is mostly working. I only miss design for the 1 point above, but it can already be tested and reviewed. Thanks

@DonKoko DonKoko assigned carlosvirreira and jurrejansen and unassigned DonKoko Apr 10, 2023
@jurrejansen
Copy link

jurrejansen commented Apr 13, 2023

@DonKoko some things i noticed

  • After clicking the 'Categories' filter the text input isn't activated and you have to click it before you are able to start typing/searching for a category

  • After clicking the text input and typing 1 character the input gets deactivated and you have to click the input again

Screen.Recording.2023-04-11.at.14.53.38.mov

@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 13, 2023

Thanks @jurrejansen . I am aware of this issues, but I was having trouble fixing it. I will take care of it.

@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 13, 2023

@jurrejansen one more thing. Can you please give me a design for the point above that is missing. Thanks

@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 14, 2023

  • After clicking the text input and typing 1 character the input gets deactivated and you have to click the input again

At the moment I am not able to solve this. Radix UI has some strong focusing functionality that overrides all my attempts and I just cant solve it. I will ask a question on the radix GH, hopefully someone can help

DonKoko added a commit that referenced this issue Apr 14, 2023
…ing category filtering dropdown checkmarks to custom to prevent radix taking over the focus. Issue #70
@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 18, 2023

@carlosvirreira this is fixed. Can you please test it and lmk. Thanks

@carlosvirreira
Copy link
Contributor

It's fixed.

GG

@DonKoko
Copy link
Contributor Author

DonKoko commented Apr 19, 2023

@carlosvirreira I have also deployed the clear filters button.

@DonKoko DonKoko unpinned this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants