Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to properly remove Unavailable and In custody assets from a booking #968

Closed
jurrejansen opened this issue May 10, 2024 · 0 comments · Fixed by #975
Closed
Assignees
Labels
bug Something isn't working

Comments

@jurrejansen
Copy link

Contact Details

jurre@shelf.nu

What happened?

Steps to reproduce:

  1. Add 2 assets to a booking and Reserve
  2. Make 1 asset unavailable for bookings and assign custody to 1 asset
  3. Go to booking page and try to remove them straight via the index
  4. See error

It's possible to remove the In custody asset via the Manage assets modal. It is impossible to remove the Unavailable for bookings asset because it will not appear in the Manage asset modal at all.

Screen.Recording.2024-05-10.at.11.33.13.mov

What is the expected behaviour?

Removing the asset via the index should work.

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

@jurrejansen jurrejansen added the bug Something isn't working label May 10, 2024
@DonKoko DonKoko linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants