Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exec): consistent error message for maxBuffer #919

Merged
merged 2 commits into from Dec 3, 2018
Merged

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Dec 3, 2018

This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.

Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.

Fixes #915

This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.

This also supports the change in Node v10, which emits this as a
RangeError instead of a regular Error.

Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.

Fixes #915
@nfischer nfischer added the fix label Dec 3, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 3, 2018

Codecov Report

Merging #919 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   97.32%   97.34%   +0.01%     
==========================================
  Files          34       34              
  Lines        1271     1280       +9     
==========================================
+ Hits         1237     1246       +9     
  Misses         34       34
Impacted Files Coverage Δ
src/exec-child.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb72ed...5b4417b. Read the comment docs.

@nfischer nfischer merged commit e606706 into master Dec 3, 2018
4 checks passed
@nfischer nfischer deleted the fix-exec-10 branch Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants