Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types broken on 12.0.3 #2829

Closed
thibault60000 opened this issue May 24, 2024 · 4 comments
Closed

Types broken on 12.0.3 #2829

thibault60000 opened this issue May 24, 2024 · 4 comments
Labels

Comments

@thibault60000
Copy link

Hi,

Types are broken. On package.json sheperd.js folder :

 "types": "shepherd.d.ts",
  "typesVersions": {
    "*": {
      "*": [
        "./dist/*"
      ]
    }
  },

On my project :
node_modules/shepherd.js/src/types/shepherd.d.ts' is not a module.ts(2306)

Types isn't on src/types/ folder but on the dist ..

@chuckcarpenter
Copy link
Member

@thibault60000 is this still the case on 12.0.4? @RobbieTheWagner did a bunch to correct some janky workarounds and perhaps paths have changed? typesVersions is gone the the package file now looks like this:

"main": "./dist/cjs/shepherd.cjs",
  "module": "./dist/esm/shepherd.mjs",
  "exports": {
    ".": {
      "import": {
        "types": "./dist/esm/shepherd.d.ts",
        "default": "./dist/esm/shepherd.mjs"
      },
      "require": {
        "types": "./dist/cjs/shepherd.d.cts",
        "default": "./dist/cjs/shepherd.cjs"
      }
    },
    "./*": {
      "import": {
        "types": "./dist/esm/*.d.ts",
        "default": "./dist/esm/*.mjs"
      },
      "require": {
        "types": "./dist/cjs/*.d.cts",
        "default": "./dist/cjs/*.cjs"
      }
    }
  },

@thibault60000
Copy link
Author

Ok. Maybe a bug with old package version.. I will try tomorroW 👍

@RobbieTheWagner
Copy link
Member

@thibault60000 does 12.0.4 work for you?

@thibault60000
Copy link
Author

@thibault60000 does 12.0.4 work for you?

Yes it's good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants