Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Remove polyfill.io #2605

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 1, 2024

The shepherd website uses polyfll.io. The PR replaces polyfill.io with cdnjs.cloudflare.com/polyfill.


polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, AlistGo/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

@RobbieTheWagner
Copy link
Member

Thanks for the info @SukkaW! I think we could remove this entirely, instead of replacing, as we no longer support IE. Would you like to make that change?

@SukkaW
Copy link
Contributor Author

SukkaW commented Mar 1, 2024

Thanks for the info @SukkaW! I think we could remove this entirely, instead of replacing, as we no longer support IE. Would you like to make that change?

Sure! Let me just update my branch real quick!


Update

@RobbieTheWagner I've rebased the PR and the polyfill.io is removed (instead of replaced).

@SukkaW SukkaW changed the title 📝 Replace polyfill.io 📝 Remove polyfill.io Mar 1, 2024
@RobbieTheWagner RobbieTheWagner merged commit 4896dbc into shipshapecode:master Mar 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants