Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined object - Thermostat --> Reminders #18

Open
fowlerk opened this issue Nov 20, 2020 · 1 comment
Open

Undefined object - Thermostat --> Reminders #18

fowlerk opened this issue Nov 20, 2020 · 1 comment

Comments

@fowlerk
Copy link

fowlerk commented Nov 20, 2020

If the Selection parameter 'include reminders = True' is specified for the call to request_thermostats, and reminders are returned in the response contents, a key error occurs. This is apparently because of an undefined object for Reminders, which include the following attributes: type, title, description, reminderDate, and remindMe. (All are six.text_type except the last, which is bool.)

The Ecobee website documentation mentions an object ThermostatReminder2[] as an attribute of the Thermostat object, but I have not found a definition for this object. The Pyecobee library includes references for this object, including in the attribute_type_map in thermostat.py. However, it appears the object name should be Reminder (as this is the key returned in the response) and a new definition created for it (reminder.py).

@fowlerk
Copy link
Author

fowlerk commented Nov 20, 2020

See my suggested changes to address: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant