Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Remaining work #74

Closed
2 of 3 tasks
xoofx opened this issue Sep 26, 2017 · 8 comments
Closed
2 of 3 tasks

[cmake] Remaining work #74

xoofx opened this issue Sep 26, 2017 · 8 comments

Comments

@xoofx
Copy link
Collaborator

xoofx commented Sep 26, 2017

Just opening an issue to track the remaining work on cmake.
There are a few remaining steps to backport from the old makefile to the cmake-transition branch:

  • dft
  • dft_tester
  • gencoef

Once this is done, we could remove all the previous makefiles and the cmake-transition branch could be merged back on master.
There is also the #71, but not sure it is critical to have it entirely ready on cmake-transition for now. It could be done later.

I can help in the process on working on a bit on these steps.

@shibatch
Copy link
Owner

You don't need to include gencoef. This is independent from the other parts.

It is of course okay to work on dft and dft_tester, but I think adding iut building for MSVC has greater priority.
We also need to check if the new build system works on every combination of OS and compiler.

@fpetrogalli
Copy link
Collaborator

I think we should also add the Intel compiler on Travis to make cmake-transition fully compatible with the original Makefile system.

@shibatch
Copy link
Owner

Does it take time to add aarch64 to Travis?
And aarch32, if possible.

@shibatch
Copy link
Owner

shibatch commented Dec 2, 2017

Adding cmake support for dft and dft_tester is almost done.
I am now thinking about removing makefiles.

Linking with libmpfr on Windows is not implemented, and I don't have prospect for this. I think an easy way is to leave makefile for this purpose. This makefile will build iut with Cygwin, and do testing.
Small makefiles will still be needed in order to do cleanup.

There are still a few things to be done.

  • AVX512F detection is not working correctly.
  • AARCH32 support has to be added
  • Intel Compiler support has to be added

@xoofx
Copy link
Collaborator Author

xoofx commented Dec 2, 2017

Let me quickly check if I can setup libmpfr on Windows

@xoofx
Copy link
Collaborator Author

xoofx commented Dec 5, 2017

Just an update, I looked at libmpfr on Windows, and it looks like a bit messy in order to get it compile, as it brings 2 unofficial repositories in the dependency + a fork to add cmake compilation integrated.

@shibatch
Copy link
Owner

shibatch commented Dec 5, 2017

Okay, thanks.
I will try to write files for building and testing with Cygwin.

@fpetrogalli
Copy link
Collaborator

Windows testing is supported since #128, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants