include owner in local path when cloning a repository #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
force-pushed
the
linux
branch
6 times, most recently
from
869bbfa
to
7d7f307
Compare
shiftkey
changed the title
shiftkey
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
I closed out the original issue because I didn't have bandwidth to see what supporting this looks like, so I'm grateful you took the time. And I'll also mention that I may need to drop this later if we get pushback or if the upstream project wishes for us to not change this behaviour (e.g. if they see support issues on this).
But otherwise, this change feels simple enough, so I'm going to merge this in so it's available in our next release. Thanks for taking the time to contribute @bala!
shiftkey
pushed a commit
that referenced
this pull request
Aug 24, 2021
shiftkey
pushed a commit
that referenced
this pull request
Aug 24, 2021
shiftkey
pushed a commit
that referenced
this pull request
Aug 24, 2021
shiftkey
pushed a commit
that referenced
this pull request
Aug 24, 2021
shiftkey
pushed a commit
that referenced
this pull request
Aug 24, 2021
shiftkey
pushed a commit
that referenced
this pull request
Aug 24, 2021
|
I recommend we revert this change. This introduces the #585 bug, and also many users like me don't want the username as part of the path. Can we at least get an option to choose? |
shiftkey
pushed a commit
that referenced
this pull request
Aug 29, 2021
shiftkey
pushed a commit
that referenced
this pull request
Sep 1, 2021
shiftkey
pushed a commit
that referenced
this pull request
Sep 5, 2021
shiftkey
pushed a commit
that referenced
this pull request
Sep 5, 2021
shiftkey
pushed a commit
that referenced
this pull request
Sep 5, 2021
shiftkey
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
github/desktop #[5449]
shiftkey/desktop #[570]
Description
parsed.owner adds the repo owner to the path - helps while cloning 2 repos with same name but from different owners ( Primarily while Forking)
Screenshots
Before:
After:
Release notes
Notes: