Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated GIFs are hit or miss #2

Closed
shiimizu opened this issue Mar 5, 2020 · 1 comment
Closed

Animated GIFs are hit or miss #2

shiimizu opened this issue Mar 5, 2020 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@shiimizu
Copy link
Owner

shiimizu commented Mar 5, 2020

Some GIFs aren't converting to the correct images to get the matching checksums.
This can be seen with running tg on dance.gif.

Some leads

For some image types, the presence of channels and bits values can be a bit confusing. As an example, GIF always uses 3 channels per pixel, but the number of bits per pixel cannot be calculated for an animated GIF with a global color table.
~ getimagesize manual

Something related to colors or compression for animated GIFs seems to be going on.

@shiimizu shiimizu added bug Something isn't working help wanted Extra attention is needed labels Mar 5, 2020
@shiimizu
Copy link
Owner Author

shiimizu commented Jun 9, 2020

Fixed in b122b7f

@shiimizu shiimizu closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant