Fix CI #335
Merged
Fix CI #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Looks like there was some more, I think to safely render these snapshots across windows and linux etc we might need a clever ish regex to remove the width=x and height=x from the snapshots? |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SVG rendering PR improvements in #290 ( /cc @TheFedaikin ) are OS dependent and can't be used on our CI ( for example on my computer (linux) :
So, I've amended the tests to not verify the full snapshots and only to measure the viewBox width - which is kinda the key of the test. If you're up for it, I'll happily take PRs adding what you want to those tests but I'm cool with these changes
Also updates the pnpm lockfile because it did it