Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add jl alias for Julia #605

Closed
wants to merge 1 commit into from
Closed

fix: add jl alias for Julia #605

wants to merge 1 commit into from

Conversation

Odilf
Copy link

@Odilf Odilf commented Feb 29, 2024

Description

Julia files have a .jl extension, so it would be a good idea to add a jl alias for the language.

This is useful for me because I'm working on a project where I want to highlight dynamically based on the file extension, and I suspect this is hardly uncommon.

This could be done manually today by consumers of the library with langAlias but I think it's reasonable to include the main file extension for Julia.

Linked Issues

N/A

Additional context

No tests are provided because as far as I can tell languages aliases aren't tested. Besides, I think it's a very simple change so it's easy to tell if it's correct or not.

Thanks!

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for shiki-next failed.

Name Link
🔨 Latest commit 35ec739
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/65e06ce1f9887a000868dcaf

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for shiki-matsu failed.

Name Link
🔨 Latest commit 35ec739
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/65e06ce1b3bfe40008f4a027

@Odilf
Copy link
Author

Odilf commented Feb 29, 2024

Netlify deploy is failing due to typo in a link, seems to be due to what was fixed in 0ab9a2d

@antfu
Copy link
Member

antfu commented Feb 29, 2024

This file is generated. You need to send PR to https://github.com/shikijs/textmate-grammars-themes instead. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants