今年よく使ったオカズのランキングを年間統計ページに追加 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
============================================
- Coverage 37.60% 37.47% -0.14%
- Complexity 787 791 +4
============================================
Files 94 94
Lines 2593 2602 +9
============================================
Hits 975 975
- Misses 1618 1627 +9
Continue to review full report at Codecov.
|
hinaloe
approved these changes
Dec 30, 2021
| $dateSince = Carbon::minValue(); | ||
| } | ||
| if ($dateUntil === null) { | ||
| $dateUntil = now()->addMonth()->startOfMonth(); |
There was a problem hiding this comment.
機能としては実害はないはずなんだけど Carbon\Carbon::setTestNow('2022-01-30') みたいなケースでガバそう
There was a problem hiding this comment.
確かに…
これちょっと上の関数とかも同じ感じになってて、あまりよくないですね…
|
@eai04191 追加しました〜
|
eai04191
reviewed
Dec 31, 2021
eai04191
approved these changes
Dec 31, 2021
|
@eai04191 やりました
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今年よく使ったオカズを振り返る枠を年間統計ページに追加します。
2回以上使っているオカズを10位まで並べます。
年末企画として直接本番に上げたいです。(なので、master宛)
Screenshot