Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support archives #64

Closed
midzer opened this issue Oct 21, 2020 · 4 comments
Closed

Support archives #64

midzer opened this issue Oct 21, 2020 · 4 comments
Labels
idea-backlog Marking closed issues as ideas for later

Comments

@midzer
Copy link
Contributor

midzer commented Oct 21, 2020

Hello,

I think it would be awesome if gohls can look into non-compressed archives (zip/rar) as well and do ffmpeg with its video on the fly.

What do you think about that?

Cya
midzer

@shimberger
Copy link
Owner

Thanks for the Idea :) It sounds like a cool feature but I am not sure how to implement it. I suspect it would make the code quite complex since right now we are calling ffmpeg with a filename and capturing stdout for encoding. I guess we would have to temporarily unpack the files but then we are using the space anyway and the idea of using archives almost seems moot.

If you have a good way to implement it, let me know. In general I am happy to accept all kinds of PRs if someone finds it useful but this one sounds like it could make things complicated.

@midzer
Copy link
Contributor Author

midzer commented Oct 22, 2020

I did some investigation. Maybe https://github.com/mholt/archiver does the trick:

Stream files in and out of archives without needing actual files on disk

@shimberger
Copy link
Owner

Thanks for all the research. I am not sure it is feasible to stream into ffpmeg since AFAIK ffmpeg needs to seek around the file to find the position and it can't do that with a stream. Are you willing to do an experiment? What's the use case? Do you have uncompressed media that is stored in archives? I don't want to discourage you I am just not sure it won't make things more complicated.

@shimberger shimberger added the idea-backlog Marking closed issues as ideas for later label Jan 22, 2022
@shimberger
Copy link
Owner

I'm closing this issue for now but put it in the idea-backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea-backlog Marking closed issues as ideas for later
Projects
None yet
Development

No branches or pull requests

2 participants