Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dcm2niix in CI #28

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Install dcm2niix in CI #28

merged 2 commits into from
Jul 21, 2020

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Jul 20, 2020

Fixes #27

This upgrades the CI environment from Ubuntu 16.04 LTS (which is Very Old now) to 18.04 (which is Current Boring Mainline), because 16.04 is too old to have dcm2niix available, but 18.04 does and is probably closer to what most people are running anyway!

@kousu
Copy link
Contributor Author

kousu commented Jul 20, 2020

Tagging both Julien and Alex; but you can sort out which of you reviews this first.

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! much more elegant approach than what i suggested. when we will be testing other OSs we might want to find an alternative solution

@kousu
Copy link
Contributor Author

kousu commented Jul 21, 2020

Yeah. Well. In my opinion conda counts as a separate OS, just like Java or docker does. Except there's always some lhttps://www.joelonsoftware.com/2002/11/11/the-law-of-leaky-abstractions/eakiness from the underlying platform, so I would rather just adapt to that platform directly than trying to paper over it. This is the approach advocated by Drew Devault.

That would means on macOS running brew install dcm2niix and on Windows choco install dcm2niix or using curl'ing the prebuilt binaries for Windows. Those are the most canonical ways to install out-of-language dependencies for those platforms. In broader context, eventually, someone could package shimming-toolbox into brew or apt and add the dependency in their brew/apt build script; if we used conda in our code then packagers for those platforms would need to do surgery to remove it and fit the package in to their system. It's not impossible, but it's somewhat unfriendly.

@kousu kousu merged commit 61f27c5 into master Jul 21, 2020
@kousu kousu deleted the ko/27-dcm2niix-ci branch July 21, 2020 15:13
@po09i po09i added testing Related to the testing process Repo Does not affect the plugin or Shimming Toolbox packages labels Aug 14, 2024
@po09i po09i added this to the 0.1 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repo Does not affect the plugin or Shimming Toolbox packages testing Related to the testing process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install dcm2niix for testing suite
3 participants