Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grue sounds not working in servers #17

Closed
ThsHaunted124 opened this issue Jul 22, 2019 · 3 comments
Closed

Grue sounds not working in servers #17

ThsHaunted124 opened this issue Jul 22, 2019 · 3 comments

Comments

@ThsHaunted124
Copy link

Description:

So in singleplayer the warning sounds of grue and the jumpscare sounds work. But when i join my friends server with this mod the sounds dont work.

Affected versions ("latest" is NOT a version):

  • Minecraft: 1.12.2
  • Forge: 14.23.5.2838
  • Grue: Grue-1.12.2-1.4.0.jar
@ThexXTURBOXx
Copy link

The issue is a bit more complicated than that...
With VanillaFix installed, it even detects some crashes (it crashes once every second):
https://pastebin.com/p4bjRiim

@Shinoow
Copy link
Owner

Shinoow commented Sep 17, 2019

Turns out I missed a minor thing in the 1.12 port, which in turn leads to the sounds not getting registered on the server (no idea how they still managed to get registered on the client). But no, the game doesn't crash, that's VanillaFix overreacting, acting as if the game crashed when in fact all that happened was the client failing to process a network packet from the server (which merely prints that error stack trace in the log).
This will be fixed in the next update.

@ThexXTURBOXx
Copy link

Okay, I already thought, that it's not a "full crash".
So, it really was that minor error I proposed?
Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants