Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting the GLTF example of Gunnerus #128

Merged
merged 37 commits into from
Aug 17, 2020
Merged

Conversation

ferrari212
Copy link
Contributor

Insertion of Gunnerus GLTF and supporting codes necessary for ensuring the compatibility with the current revision 118 of THREE.js

icarofonseca and others added 10 commits November 18, 2019 18:41
Update salt cave simulation
Link ObservableHQ examples to homepage
Remove redundant Play/Pause button from GUI in epoch example.
Change the catenary visualization snippet to use a class syntax.
Update Ship visualization example
Clean and organize examples. Improvements to Epoch example, add Gunnerus STL files.
Inserting Featuare in Epoch Example
Update your fork from master
Copy link
Contributor Author

@ferrari212 ferrari212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code

@@ -203,12 +202,247 @@
return 0;
}

function mo2() {
return states.continuous.motion.roll
gui.add(obj, "Click to read paper")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferrari212 This excerpt is repeated.

.prettierignore Outdated
@@ -0,0 +1,2 @@
# Ignore artifacts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental commit?

@icarofonseca icarofonseca merged commit 9c34de3 into shiplab:dev Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants