Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmos sprite update #2136

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Conversation

SapphicOverload
Copy link
Contributor

About The Pull Request

Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe cabinet to fit in with the rest of the engineering sprites. Also, fireaxe item sprite is no longer upside down when unwielded.
image
image

Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199

Why It's Good For The Game

Makes atmos firesuit and axe sprites fit in with the newer engineering sprites, also I think it looks nice.

Changelog

馃啈
imageadd: updates some atmos sprites to fit in with the rest of engineering
/:cl:

@SapphicOverload SapphicOverload requested a review from a team as a code owner July 6, 2023 04:49
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Merge Conflict Use Git Hooks, you're welcome. labels Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@thgvr
Copy link
Member

thgvr commented Jul 14, 2023

Sorry we didn't get to your pr, can you fix the conflicts here?

@SapphicOverload
Copy link
Contributor Author

Ah right my bad, I'll go fix that

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jul 17, 2023
@SapphicOverload
Copy link
Contributor Author

Fixed the merge conflict

@thgvr thgvr added this pull request to the merge queue Jul 17, 2023
Merged via the queue into shiptest-ss13:master with commit 2e8dcc8 Jul 17, 2023
10 checks passed
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe
cabinet to fit in with the rest of the engineering sprites. Also,
fireaxe item sprite is no longer upside down when unwielded.

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/24f75111-dd9c-42f5-b35d-e52e53ad03fa)

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/93b1e744-f0b9-4119-9142-17e5a664ea87)

Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199

## Why It's Good For The Game
Makes atmos firesuit and axe sprites fit in with the newer engineering
sprites, also I think it looks nice.

## Changelog

:cl:
imageadd: updates some atmos sprites to fit in with the rest of
engineering
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe
cabinet to fit in with the rest of the engineering sprites. Also,
fireaxe item sprite is no longer upside down when unwielded.

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/24f75111-dd9c-42f5-b35d-e52e53ad03fa)

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/93b1e744-f0b9-4119-9142-17e5a664ea87)

Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199

## Why It's Good For The Game
Makes atmos firesuit and axe sprites fit in with the newer engineering
sprites, also I think it looks nice.

## Changelog

:cl:
imageadd: updates some atmos sprites to fit in with the rest of
engineering
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants