Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds atmospheric gloves, small resprite of firefighter gear, repaths stupid glove paths #72736

Merged
merged 12 commits into from Jan 17, 2023

Conversation

Fikou
Copy link
Member

@Fikou Fikou commented Jan 15, 2023

About The Pull Request

repaths a lot of gloves off /color because they were incredibly stupid
firefighter gear has gotten an update (it doesnt cover hands anymore though, you need something else)
firefighter helmets no longer hide your mask or glasses
image
fixed engine goggles starting with darkness vision
to the atmos lockers adds atmospheric gloves, a pair of thick (chunky fingers) gloves that are fireproof and fire protective, slightly shock resistant and let you fireman carry people faster.
atmospheric firefighter helmets now are a subtype of welding hardhats, you can enable a welding visor.
welding hardhats change mode with right click instead of altclick

Why It's Good For The Game

im not a good spriter but i think this resprite makes them fit nicer with other engi equipment
lets me firefighter rp

Changelog

🆑
add: Atmospheric Gloves, thick gloves that are fully fireproof and fire protective and let you fireman carry people faster.
fix: fixes engine goggles starting with darkness vision
qol: firefighter helmets can now enable a welding visor
qol: welding hardhats change mode with right click instead of altclick
balance: firesuits no longer protect your hands
/:cl:

@tgstation-server tgstation-server added Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. Sprites A bikeshed full of soulless bikes. labels Jan 15, 2023
@MaineTheMan
Copy link

can we see the gloves tho

@private-tristan
Copy link
Contributor

(it doesnt cover hands anymore though, you need something else)

Does this apply to all firefighting gear? If so then wouldn't this make firefighting lockers mostly useless unless you already found black gloves?

@Fikou
Copy link
Member Author

Fikou commented Jan 15, 2023

(it doesnt cover hands anymore though, you need something else)

Does this apply to all firefighting gear? If so then wouldn't this make firefighting lockers mostly useless unless you already found black gloves?

it doesnt
also, hands are a minor part of your body, they take a while to heat up

@Fikou
Copy link
Member Author

Fikou commented Jan 16, 2023

can we see the gloves tho

press icon diff bot 2
you can also see them on the character in the firesuit

@MaineTheMan
Copy link

can we see the gloves tho

press icon diff bot 2 you can also see them on the character in the firesuit

i have no idea what that means, also its pretty hard to see whats the firesuit and whats the gloves since its black on black

@san7890
Copy link
Member

san7890 commented Jan 16, 2023

press icon diff bot 2 you can also see them on the character in the firesuit

i have no idea what that means, also its pretty hard to see whats the firesuit and whats the gloves since its black on black

https://github.com/tgstation/tgstation/pull/72736/checks?check_run_id=10662058876

Copy link
Contributor

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good sprites, nothing more to say.

@tralezab tralezab merged commit f62c491 into tgstation:master Jan 17, 2023
comfyorange added a commit that referenced this pull request Jan 17, 2023
github-actions bot added a commit that referenced this pull request Jan 17, 2023
optimumtact pushed a commit that referenced this pull request Jan 17, 2023
## About The Pull Request
Adds an updatepaths script for #72736 
Turned `72479_replace_faithless` into a .txt file for consistency

## Why It's Good For The Game

#72736 changes the paths of some very common items seen throughout the
game, such as hardhats and nitrile gloves. This PR adds an updatepaths
script for such revisions.

## Changelog

code improvement, no player facing changes, whatever you call it. I
can't be bothered.
Jolly-66 added a commit to TaleStation/TaleStation that referenced this pull request Jan 19, 2023
…fighter gear, repaths stupid glove paths (#4153)

Original PR: tgstation/tgstation#72736
-----
## About The Pull Request
repaths a lot of gloves off /color because they were incredibly stupid
firefighter gear has gotten an update (it doesnt cover hands anymore
though, you need something else)
firefighter helmets no longer hide your mask or glasses

![image](https://user-images.githubusercontent.com/23585223/212542599-c004d0e4-c141-40b4-a1bb-c838f9893c4b.png)
fixed engine goggles starting with darkness vision
to the atmos lockers adds atmospheric gloves, a pair of thick (chunky
fingers) gloves that are fireproof and fire protective, slightly shock
resistant and let you fireman carry people faster.
atmospheric firefighter helmets now are a subtype of welding hardhats,
you can enable a welding visor.
welding hardhats change mode with right click instead of altclick

## Why It's Good For The Game
im not a good spriter but i think this resprite makes them fit nicer
with other engi equipment
lets me firefighter rp

## Changelog
:cl:
add: Atmospheric Gloves, thick gloves that are fully fireproof and fire
protective and let you fireman carry people faster.
fix: fixes engine goggles starting with darkness vision
qol: firefighter helmets can now enable a welding visor
qol: welding hardhats change mode with right click instead of altclick
balance: firesuits no longer protect your hands
/:cl:

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
@san7890 san7890 added this to the Mega-Mega-Map-Reworks milestone Jan 20, 2023
MrMelbert pushed a commit that referenced this pull request Jun 21, 2023
#72736 added the firefighter gloves to atmos techs which lets them quick
carry wounded people faster.
Firefighting RP is fun, so this PR just gives the quick carry module to
the Atmos MODsuit. Now they don't miss on the best part of the job!!!
github-merge-queue bot pushed a commit to shiptest-ss13/Shiptest that referenced this pull request Jul 17, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe
cabinet to fit in with the rest of the engineering sprites. Also,
fireaxe item sprite is no longer upside down when unwielded.

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/24f75111-dd9c-42f5-b35d-e52e53ad03fa)

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/93b1e744-f0b9-4119-9142-17e5a664ea87)

Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199

## Why It's Good For The Game
Makes atmos firesuit and axe sprites fit in with the newer engineering
sprites, also I think it looks nice.

## Changelog

:cl:
imageadd: updates some atmos sprites to fit in with the rest of
engineering
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe
cabinet to fit in with the rest of the engineering sprites. Also,
fireaxe item sprite is no longer upside down when unwielded.

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/24f75111-dd9c-42f5-b35d-e52e53ad03fa)

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/93b1e744-f0b9-4119-9142-17e5a664ea87)

Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199

## Why It's Good For The Game
Makes atmos firesuit and axe sprites fit in with the newer engineering
sprites, also I think it looks nice.

## Changelog

:cl:
imageadd: updates some atmos sprites to fit in with the rest of
engineering
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe
cabinet to fit in with the rest of the engineering sprites. Also,
fireaxe item sprite is no longer upside down when unwielded.

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/24f75111-dd9c-42f5-b35d-e52e53ad03fa)

![image](https://github.com/shiptest-ss13/Shiptest/assets/93578146/93b1e744-f0b9-4119-9142-17e5a664ea87)

Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199

## Why It's Good For The Game
Makes atmos firesuit and axe sprites fit in with the newer engineering
sprites, also I think it looks nice.

## Changelog

:cl:
imageadd: updates some atmos sprites to fit in with the rest of
engineering
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances Map Edit Thank you for your tile-placing service. It's always appreciated. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants