Resprites the fireaxe inhands, 3/4th-ifies the fire axe cabinet #65199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ebin-Halcyon
requested review from
Twaticus,
Krysonism and
Imaginos16
as code owners
|
You currently have a negative Fix/Feature pull request delta of -8. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
|
the axehead looks a bit big but nice otherwise |
|
the fire axe in cabinet looks like its just sticking out a bit. |
o shit didn't even notice that, give me a second. |
Ebin-Halcyon
changed the title
tgstation-server
added a commit
that referenced
this pull request
Feb 28, 2022
|
very good |
github-merge-queue bot
pushed a commit
to shiptest-ss13/Shiptest
that referenced
this pull request
Jul 17, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe cabinet to fit in with the rest of the engineering sprites. Also, fireaxe item sprite is no longer upside down when unwielded.   Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199 ## Why It's Good For The Game Makes atmos firesuit and axe sprites fit in with the newer engineering sprites, also I think it looks nice. ## Changelog :cl: imageadd: updates some atmos sprites to fit in with the rest of engineering /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MarkSuckerberg
pushed a commit
to MarkSuckerberg/Shiptest
that referenced
this pull request
Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe cabinet to fit in with the rest of the engineering sprites. Also, fireaxe item sprite is no longer upside down when unwielded.   Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199 ## Why It's Good For The Game Makes atmos firesuit and axe sprites fit in with the newer engineering sprites, also I think it looks nice. ## Changelog :cl: imageadd: updates some atmos sprites to fit in with the rest of engineering /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MarkSuckerberg
pushed a commit
to MarkSuckerberg/Shiptest
that referenced
this pull request
Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Updates the sprites for the atmos firesuit, inhand fireaxe, and fireaxe cabinet to fit in with the rest of the engineering sprites. Also, fireaxe item sprite is no longer upside down when unwielded.   Sprites are from tgstation/tgstation#72736 and tgstation/tgstation#65199 ## Why It's Good For The Game Makes atmos firesuit and axe sprites fit in with the newer engineering sprites, also I think it looks nice. ## Changelog :cl: imageadd: updates some atmos sprites to fit in with the rest of engineering /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
What it says on the tin, resprites the fire axe inhands, worn, and in cabinet sprite to be inline with the obj sprite
unknown_2022.02.27-16.05_Trim.mp4
3/4th-ified cabinet + breaking states
unknown_2022.02.28-13.15.mp4
unknown_2022.02.28-13.16_Trim.mp4
Why It's Good For The Game
less jarringly different sprites for the inhand and obj sprites.
Was asked to do this by Imaginos after I tinkered with an energy fire axe.
Changelog
馃啈
imageadd: New fireaxe inhand, worn, and in cabinet sprites.
/:cl: