Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports Assorted Do_After Chicanary #2207

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

Bjarl
Copy link
Contributor

@Bjarl Bjarl commented Jul 29, 2023

About The Pull Request

ports 50840, 52521, and 55146 from /tg/station

Why It's Good For The Game

Makes it easier to balance stuff + removes absurd instant heals and the need to check if something can allow a stacked do_after

Changelog

🆑 Mothblocks, Ryll-Ryll, ported by Erika
add: CPR will now automatically repeat, but you can no longer do it multiple times at once.
fix: The INTERACTING_WITH macro now tracks all kinds of do_after
code: Users can only queue one do_after per target at a time
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Jul 29, 2023
@Redrover1760
Copy link

Torture.

@MarkSuckerberg MarkSuckerberg added this pull request to the merge queue Aug 10, 2023
Merged via the queue into shiptest-ss13:master with commit bc96ba8 Aug 10, 2023
10 checks passed
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports 50840, 52521, and 55146 from /tg/station
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes it easier to balance stuff + removes absurd instant heals and the
need to check if something can allow a stacked do_after
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Mothblocks, Ryll-Ryll, ported by Erika
add: CPR will now automatically repeat, but you can no longer do it
multiple times at once.
fix: The INTERACTING_WITH macro now tracks all kinds of do_after
code: Users can only queue one do_after per target at a time
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports 50840, 52521, and 55146 from /tg/station
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes it easier to balance stuff + removes absurd instant heals and the
need to check if something can allow a stacked do_after
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Mothblocks, Ryll-Ryll, ported by Erika
add: CPR will now automatically repeat, but you can no longer do it
multiple times at once.
fix: The INTERACTING_WITH macro now tracks all kinds of do_after
code: Users can only queue one do_after per target at a time
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Aug 11, 2023
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
ports 50840, 52521, and 55146 from /tg/station
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes it easier to balance stuff + removes absurd instant heals and the
need to check if something can allow a stacked do_after
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: Mothblocks, Ryll-Ryll, ported by Erika
add: CPR will now automatically repeat, but you can no longer do it
multiple times at once.
fix: The INTERACTING_WITH macro now tracks all kinds of do_after
code: Users can only queue one do_after per target at a time
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to MarkSuckerberg/Shiptest that referenced this pull request Sep 13, 2023
@Bjarl Bjarl deleted the sanity branch October 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants