-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't retry flakes in integration tests #571
Conversation
Flaky behavior can hurt real users, and ignoring it to appease CI tests only hides the problem, and can make CI tests take longer. If this is too noisy, we can either spend effort fixing flakes, and/or make tests less strict, or re-enable flaky retries.
Hi @imjasonh. Thanks for your PR. I'm waiting for a shipwright-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This was done due to how unstable travis was. I´m fine merging this one, I do want to keep open the possibility for what you mentioned.
EDIT: Seems this PR is already failing on a flaky test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ironically, Prow seems to have failed with another type of flake altogether 😆
/test 4.4-unit |
Flaky behavior can hurt real users, and ignoring it to appease CI tests only hides the problem, and can make CI tests take longer.
If this is too noisy, we can either spend effort fixing flakes, and/or make tests less strict, or re-enable flaky retries.
I've run this locally 10x with #570 and didn't experience any failures. Let's see if CI agrees 😄