Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretreatment.py is causing dealock error on OUMVLP dataset #32

Closed
1 task done
gosiqueira opened this issue Jan 3, 2022 · 5 comments · Fixed by #44
Closed
1 task done

pretreatment.py is causing dealock error on OUMVLP dataset #32

gosiqueira opened this issue Jan 3, 2022 · 5 comments · Fixed by #44
Labels
bug Something isn't working

Comments

@gosiqueira
Copy link
Contributor

gosiqueira commented Jan 3, 2022

System information (version)

  • Pytorch => 1.10
  • Operating System / Platform =>Ubuntu 20.04
  • Cuda => Cuda 11.5

Detailed description

pretreatment.py for OUMVLP dataset results in random deadlocks.
Currently you are making asynchronous calls using a thread pool and storing the result e ordinary Python list. Thus, when I execute the code to convert OUMVLP files to pickles it's happening random deadlocks during the code execution.

I forked the directory and I'm trying to solve this myself to make a PR, bit I believe it's relevant to keep you apart of this problem.

Steps to reproduce

Steps:

  1. Execute the code for OUMVLP dataset using personal machine processor. The error occurs in a non-deterministic fashion.

Issue submission checklist

  • I checked the problem with documentation, FAQ, issues, and have not found solution.
@chuanfushen
Copy link
Collaborator

Awesome!

we also find this issue, but haven't pointed it out at docs.

Thanks for letting people know, and feel free to make a PR! Thanks.

@darkliang darkliang added the bug Something isn't working label Jan 4, 2022
jackhanyuan added a commit to jackhanyuan/OpenGait that referenced this issue Mar 12, 2022
@jackhanyuan
Copy link
Contributor

jackhanyuan commented Mar 12, 2022

I found that some other format files were generated in the OUMVLP_rearranged folder, so the processing would randomly break.

Just filtering the png files will solve this problem.

jackhanyuan@046083a

@chuanfushen
Copy link
Collaborator

I found that some other format files were generated in the OUMVLP_rearranged folder, so the processing would randomly break.

Just filtering the png files will solve this problem.

https://github.com/jackhanyuan/OpenGait/blob/master/misc/pretreatment.py

Okay, I see you filter png, so does it work perfectly now? Currently, I am working on verifying @gosiqueira pull_request . After I finish verification, I will try to merge both your and gosiqueira code.

@jackhanyuan
Copy link
Contributor

@noahshen98 Okay, After filtering png, it worked well.

@darkliang darkliang linked a pull request Mar 12, 2022 that will close this issue
@chuanfushen
Copy link
Collaborator

System information (version)

  • Pytorch => 1.10

  • Operating System / Platform =>Ubuntu 20.04

  • Cuda => Cuda 11.5

Detailed description

pretreatment.py for OUMVLP dataset results in random deadlocks.

Currently you are making asynchronous calls using a thread pool and storing the result e ordinary Python list. Thus, when I execute the code to convert OUMVLP files to pickles it's happening random deadlocks during the code execution.

I forked the directory and I'm trying to solve this myself to make a PR, bit I believe it's relevant to keep you apart of this problem.

Steps to reproduce

Steps:

  1. Execute the code for OUMVLP dataset using personal machine processor. The error occurs in a non-deterministic fashion.

Issue submission checklist

  • I checked the problem with documentation, FAQ, issues, and have not found solution.

Hi, I have verified the output of your modified pretreatment is identical to previous version. Besides, your modified version is much clear and understandable. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants