-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pretreatment.py
is causing dealock error on OUMVLP dataset
#32
Comments
Awesome! we also find this issue, but haven't pointed it out at docs. Thanks for letting people know, and feel free to make a PR! Thanks. |
I found that some other format files were generated in the Just filtering the png files will solve this problem. |
Okay, I see you filter png, so does it work perfectly now? Currently, I am working on verifying @gosiqueira pull_request . After I finish verification, I will try to merge both your and gosiqueira code. |
@noahshen98 Okay, After filtering png, it worked well. |
Hi, I have verified the output of your modified pretreatment is identical to previous version. Besides, your modified version is much clear and understandable. Thanks for your contribution. |
System information (version)
Detailed description
pretreatment.py
for OUMVLP dataset results in random deadlocks.Currently you are making asynchronous calls using a thread pool and storing the result e ordinary Python list. Thus, when I execute the code to convert OUMVLP files to pickles it's happening random deadlocks during the code execution.
I forked the directory and I'm trying to solve this myself to make a PR, bit I believe it's relevant to keep you apart of this problem.
Steps to reproduce
Steps:
Issue submission checklist
The text was updated successfully, but these errors were encountered: