Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate code in mktypes.sh #1646

Merged
merged 1 commit into from
May 13, 2024

Conversation

zhanluxianshen
Copy link
Contributor

/kind cleanup

remove duplicate code in mktypes.sh

Signed-off-by: zhanluxianshen <irelandabby883@gmail.com>
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Thanks!

@shirou shirou merged commit 193aafb into shirou:master May 13, 2024
23 checks passed
@zhanluxianshen
Copy link
Contributor Author

Thanks

@zhanluxianshen zhanluxianshen deleted the clean-mktypes.sh branch May 13, 2024 21:18
codeboten added a commit to open-telemetry/opentelemetry-collector that referenced this pull request Jun 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/shirou/gopsutil/v3](https://togithub.com/shirou/gopsutil)
| `v3.24.4` -> `v3.24.5` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.4/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.4/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>shirou/gopsutil (github.com/shirou/gopsutil/v3)</summary>

###
[`v3.24.5`](https://togithub.com/shirou/gopsutil/releases/tag/v3.24.5)

[Compare
Source](https://togithub.com/shirou/gopsutil/compare/v3.24.4...v3.24.5)

<!-- Release notes generated using configuration in .github/release.yml
at v3.24.5 -->

#### What's Changed

##### cpu

- Improve AIX Support by [@&#8203;Dylan-M](https://togithub.com/Dylan-M)
in
[shirou/gopsutil#1651

##### process

- Add fallback for lsof output by
[@&#8203;MDrakos](https://togithub.com/MDrakos) in
[shirou/gopsutil#1640
- \[process]\[openbsd]: add cwd on openbsd. by
[@&#8203;shirou](https://togithub.com/shirou) in
[shirou/gopsutil#1649

##### Other Changes

- remove duplicate code in mktypes.sh by
[@&#8203;zhanluxianshen](https://togithub.com/zhanluxianshen) in
[shirou/gopsutil#1646
- add arm/arm64 category for github pr label. by
[@&#8203;zhanluxianshen](https://togithub.com/zhanluxianshen) in
[shirou/gopsutil#1647

#### New Contributors

- [@&#8203;zhanluxianshen](https://togithub.com/zhanluxianshen) made
their first contribution in
[shirou/gopsutil#1646
- [@&#8203;MDrakos](https://togithub.com/MDrakos) made their first
contribution in
[shirou/gopsutil#1640
- [@&#8203;Dylan-M](https://togithub.com/Dylan-M) made their first
contribution in
[shirou/gopsutil#1651

**Full Changelog**:
shirou/gopsutil@v3.24.4...v3.24.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jun 4, 2024
…3356)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/shirou/gopsutil/v3](https://togithub.com/shirou/gopsutil)
| `v3.24.4` -> `v3.24.5` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.4/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fshirou%2fgopsutil%2fv3/v3.24.4/v3.24.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>shirou/gopsutil (github.com/shirou/gopsutil/v3)</summary>

###
[`v3.24.5`](https://togithub.com/shirou/gopsutil/releases/tag/v3.24.5)

[Compare
Source](https://togithub.com/shirou/gopsutil/compare/v3.24.4...v3.24.5)

<!-- Release notes generated using configuration in .github/release.yml
at v3.24.5 -->

#### What's Changed

##### cpu

- Improve AIX Support by [@&#8203;Dylan-M](https://togithub.com/Dylan-M)
in
[shirou/gopsutil#1651

##### process

- Add fallback for lsof output by
[@&#8203;MDrakos](https://togithub.com/MDrakos) in
[shirou/gopsutil#1640
- \[process]\[openbsd]: add cwd on openbsd. by
[@&#8203;shirou](https://togithub.com/shirou) in
[shirou/gopsutil#1649

##### Other Changes

- remove duplicate code in mktypes.sh by
[@&#8203;zhanluxianshen](https://togithub.com/zhanluxianshen) in
[shirou/gopsutil#1646
- add arm/arm64 category for github pr label. by
[@&#8203;zhanluxianshen](https://togithub.com/zhanluxianshen) in
[shirou/gopsutil#1647

#### New Contributors

- [@&#8203;zhanluxianshen](https://togithub.com/zhanluxianshen) made
their first contribution in
[shirou/gopsutil#1646
- [@&#8203;MDrakos](https://togithub.com/MDrakos) made their first
contribution in
[shirou/gopsutil#1640
- [@&#8203;Dylan-M](https://togithub.com/Dylan-M) made their first
contribution in
[shirou/gopsutil#1651

**Full Changelog**:
shirou/gopsutil@v3.24.4...v3.24.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants