-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic for IP-based dynamic redirects #2151
Add logic for IP-based dynamic redirects #2151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this logic was originally defined in RequestTracker
, and has been extracted to be reused for IP-based redirect rules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2151 +/- ##
=============================================
+ Coverage 95.95% 95.98% +0.03%
- Complexity 1507 1520 +13
=============================================
Files 264 266 +2
Lines 5116 5137 +21
=============================================
+ Hits 4909 4931 +22
+ Misses 207 206 -1 ☔ View full report in Codecov by Sentry. |
4adce88
to
626caa4
Compare
Closes #2120
Allow redirect rule conditions based on visitors IP addresses. Condition values can be static IP addresses (100.200.80.40), CIDR blocks (192.168.10.0/24) or wildcard patterns (11.22.*.*).
Alternative implementation to #2121, with the next differences:
DISABLE_TRACKING_FROM
.RedirectRulesInputFilter
.TODO