Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution to not adding Valerkye metals to Aether Legacy Chests #13

Closed
AlexModGuy opened this issue Jan 19, 2019 · 1 comment
Closed
Labels
invalid This doesn't seem right

Comments

@AlexModGuy
Copy link

https://github.com/Alex-the-666/Ice_and_Fire/blob/1.12.2/src/main/java/com/github/alexthe666/iceandfire/event/EventLiving.java#L520

I saw that you had issues adding your own Valerkye metal to the default Aether chests. This code should help provide a solution to your problem.

@Shnupbups Shnupbups added the invalid This doesn't seem right label Feb 3, 2019
@Shnupbups
Copy link
Owner

I assume you meant to link to this line?
https://github.com/Alex-the-666/Ice_and_Fire/blob/5b87e4277521ba87ec3bf39e6baca5e9e48f1e7c/src/main/java/com/github/alexthe666/iceandfire/event/EventLiving.java#L565

The problem I have with adding the ingots to the chests cannot be solved with this method, as the Aether Legacy dungeon chests do not currently use the LootTables system, but rather have their loot generation hardcoded.

The Aether Legacy devs have plans to migrate to the LootTables system, however, and once they do my job will be simple.

But as it stands right now, it is simply not possible to use this method to add loot to the chests.

(If you did however intend to link to the line you did link to, I would really rather not fire an event every single time a chest is opened, figure out how to check if said chest is a silver dungeon chest, figure out if it's being opened for the first time, then add loot to it. That's... a bit silly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants