Region detection algorithm not always working properly

[xdev1]

Great Britain allows two different valid time formats:

• The 24-hour time format: 14:34
• The 12-hour time format: 2:34 pm

Intl uses the 24-hour time format for locale en-GB.
If you want to use the 12-hour time format for GB then you have to use locale en-GB-u-hc-h12.
Please find here a litte demo.

So now assume you are using locale en-GB-u-hc-h12. Then this line

localize/src/index.ts

Line 120 in 421744e

const regionCode = this.lang().length > 2 ? this.lang().toLowerCase() : ''; // e.g. en-gb

will fail to detect the proper code (which should be "en-gb").

Please find here a little demo that shows one case where that bug leads to wrong i18n behavior.

It might be a good idea to use new Intl.Locale('en-GB-u-hc-h12') (see here and here).

[claviska]

Nice catch. I've updated it so use Intl.Locale() and published 3.0.2. Thanks!

[claviska]

Just a heads up — 3.0.2 detects the region correctly but fails to prepend the language code to it. 🤦🏻‍♂️

Please use 3.0.3 instead, which works as intended.