fix some errors in kexpfam #4395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix available_objects namespace
…rage Test that old parameter names and tag parameter names match
…ister-raw_matrix Tag-register all raw matrices
…ister-raw_array tag-register all raw arrays
Fix directory of submodule initialization
Fix issue shogun-toolbox#3612 adds unit test functions for combined kernel subsetting behaviour. Fixes an issue in which combined kernels would not subset custom kernels if features other than combinedfeatures were passed The latter is achieved by replacing the previous recursive call with a call to a helper function made aware of any subsets contained.
this allows to extract the parameter names with parameter_names from the SWIG interface
as swig typemap for std::vector exists for all supported languages
apparently some cases the lambda with auto arg is not supported :(
…ructors and factory functions
Extend the meta-language to support keyword arguments
…constructor_AnyParameterProperties Add default arguments to AnyParameterProperties ctor
add unit tests that ensure same evaluation results as standard nystrom
…nel_exp_family some fixes to kexpfams
…nel_exp_family_sum Feature/kernel exp family sum
implement Lite::grad, hessian, hessian_diag
|
Wow, totally screwed up the |
|
I guess the PR should go against my fork's branch, not the master |
|
ah you commented, nw :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by
clangwarnings 👍