Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct channel names for voice assistants #116

Closed
StevoNL opened this issue Apr 9, 2024 · 5 comments
Closed

Correct channel names for voice assistants #116

StevoNL opened this issue Apr 9, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@StevoNL
Copy link

StevoNL commented Apr 9, 2024

Is your feature request related to a problem? Please describe.
In Home Assistant the channel names are displayed correctly. Using speech to set the input, the command is correctly executed to the correct channel, however the voice response has the leading "P" with the channel name and truncates the channel name, especially if it has a number.
Not entirely shure if this is related to this integration or to Google Assistant, but this wonderful integration's predecessor had the option to disable the "P" and it worked correctly then.

For example with Google Nest Hub:
LGHorizon

Describe the solution you'd like
If possible for the channel names not only to look right, but sound right as well.

BTW
This is hands down my favorite integration for Home Assistant up till date! Keep up the good work! 🥇

@StevoNL StevoNL added the enhancement New feature or request label Apr 9, 2024
@Sholofly
Copy link
Owner

Sholofly commented Apr 9, 2024

Where do you examine this logs?

@StevoNL
Copy link
Author

StevoNL commented Apr 9, 2024

The screenshot is from myactivity.google.com. It shows my voice prompt and the voice response from Google Assistant. It seems the channel names are passed to Google Assistant as "p NPO", "p VRT canv", "p RTL" etc.

Everything is executed perfectly by Home Assistant and there are no errors, the debug logs don't share any valuable information imo. For example: this is the log entry for a single request (key's removed):

2024-04-09 15:29:04.651 INFO (Thread-24 (_thread_main)) [lghorizon.lghorizon_api] Executing API call to https://spark-prod-nl.gnp.cloud.ziggogo.tv/eng/web/linear-service/v2/replayEvent/crid:~~2F~~2Fgn.tv~~[..........]returnLinearContent=true&language=nl

@Sholofly
Copy link
Owner

Sholofly commented Apr 9, 2024

True, I don't think its an integration issue: In my account it's reporting no p:

image

@StevoNL
Copy link
Author

StevoNL commented Apr 10, 2024

Interesting. I'll try and remove the integration from Home Assistant and Google Home and then do a reinstall. Perhaps something is still lingering somewhere now. I'll come back with more information after I tried.

@StevoNL
Copy link
Author

StevoNL commented Apr 16, 2024

Allright, an update with high failure rate... Things I've tried:

  • Remove LGHorizon integration, restarted Home Assistant, synced devices on Google Home to make sure TV is removed. Re-added LGHorizon integration, restarted Home Assistant again and installed integration, resynced devices on Google Home:
    Problem persists
  • Tried voice promts via Google Nest mini, Google Home mini, Google Nest Hub and android Phone. Tried locally via Wifi (Local fulfillment) aswell as via 5G (Cloud fulfillment):
    Problem persists
  • Redeployed Google Assistant testversion through actions.google.com:
    Problem persists

The channel names show correctly on device screens, even in Google Home, yet the voice responses remain truncated and with leading "P".
Sholofly's reply confirm my suspicion that the cause doesn't lie in the integration. I suspect it's probably caused by a cache lingering somewhere far far away, but I'm out of clues.

Thanks Sholofly for your quick response, if anyone else has the same problem, has an idea or know's the solution... I'd be happy to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants