Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix underline link on instalments and dynamic checkout #64

Closed
1 of 2 tasks
wiktoriaswiecicka-zz opened this issue Jun 18, 2021 · 2 comments
Closed
1 of 2 tasks

Fix underline link on instalments and dynamic checkout #64

wiktoriaswiecicka-zz opened this issue Jun 18, 2021 · 2 comments
Assignees
@KaichenWang
Labels
Category: Enhancement New feature or request Severity: 3 Normal/Low Severity

Comments

@wiktoriaswiecicka-zz
Copy link

There should be 3px offset on underline links to match other link styles in the theme.

  • Instalment "Learn more"
  • Dynamich checkout "More payment options"

@Guillaumegranger1
@wiktoriaswiecicka-zz wiktoriaswiecicka-zz changed the title Underline link on instalments and dynamic checkout Fix underline link on instalments and dynamic checkout Jun 18, 2021
@KaichenWang
Copy link
Contributor

This CSS can be added to the theme, but I'm not sure this code belongs in the theme.

shopify-installments__learn-more {
  text-underline-offset: 0.3rem;
}

@nicklepine nicklepine transferred this issue from another repository Jun 28, 2021
@nicklepine nicklepine added Category: Enhancement New feature or request Severity: 3 Normal/Low Severity labels Jun 28, 2021
@Stephanie-Chou
Copy link
Contributor

We are closing this issue. This issue was reported 2 years ago on an old version of Dawn. If this is still a high priority issue today, please re open with updated reproduction steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaichenWang KaichenWang

Labels
Category: Enhancement New feature or request Severity: 3 Normal/Low Severity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KaichenWang @Stephanie-Chou @nicklepine @wiktoriaswiecicka-zz