Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary section inaccurate when deploy aborted #137

Closed
KnVerey opened this issue Jul 18, 2017 · 2 comments
Closed

Summary section inaccurate when deploy aborted #137

KnVerey opened this issue Jul 18, 2017 · 2 comments
Labels
🪲 bug Something isn't working 👋 new contributor Good for newcomers

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jul 18, 2017

If you kill the deploy somewhere between the initiation and completion of an action, the deploy summary printed will be inaccurate. For example, if you abort the deploy between the predeploy and the main deploy, the summary will say "No actions taken". Ideas for solutions:

  1. Introduce a mechanism for tracking the action currently being attempted and reporting it on failure
  2. Don't print the summary section when the process has been killed
  3. Change the message printed to be more ¯\_(ツ)_/¯
@KnVerey KnVerey added the 🪲 bug Something isn't working label Jul 18, 2017
@KnVerey KnVerey added the 👋 new contributor Good for newcomers label Oct 30, 2017
@benlangfeld
Copy link
Contributor

@KnVerey Should this have been closed by https://github.com/Shopify/kubernetes-deploy/pull/244/files#r177486770 , or is there something else to be done here?

@dturn
Copy link
Contributor

dturn commented Feb 27, 2019

#244 definitely implemented (2) . The UX would be better if we'd done (1) but it hasn't come up so I think we can close this out and re-open if it comes up again.

@dturn dturn closed this as completed Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working 👋 new contributor Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants