Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid class inheritance #24

Closed
DBA opened this issue Aug 24, 2010 · 2 comments
Closed

Liquid class inheritance #24

DBA opened this issue Aug 24, 2010 · 2 comments

Comments

@DBA
Copy link

DBA commented Aug 24, 2010

Currently:

  • Document is a Tag
  • Block is a Tag
  • If is a blog, so it is a tag

I find this to make less sense than

  • Document is a Document and implements Block behaviors
  • Block is not a Tag
  • If is a Tag and implements Block behaviors

The current inheritance chain makes it hard to change document, and to some extent block, without affecting tag directly.

If this makes sense it's something that could be changed for liquid 3, effectively making it more modular and cleaner.

Best regards,
DBA

@phoet
Copy link
Contributor

phoet commented Apr 26, 2014

4 years ago... can we close this?

@arthurnn
Copy link
Contributor

arthurnn commented May 6, 2014

Closing this, as this is referring to a old version of liquid.. Please let us know if this is still a issue.

thanks

@arthurnn arthurnn closed this as completed May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants