Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ApplicationValidator checks #17

Closed
9 tasks
wildmaples opened this issue Sep 25, 2020 · 1 comment
Closed
9 tasks

Add unit tests for ApplicationValidator checks #17

wildmaples opened this issue Sep 25, 2020 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@wildmaples
Copy link
Contributor

wildmaples commented Sep 25, 2020

We have ApplicationValidatorTest which are integration tests. However, we should find a way to unit test the individual checks.

We could make unit testing this file easier by refactoring it so a fake filesystem can be injected.
This would make it easier to test but would require a larger refactor. https://github.com/Shopify/packwerk-old/pull/262#discussion_r455956863

TO DO:

  • check_autoload_path_cache,
  • check_package_manifests_for_privacy,
  • check_package_manifest_syntax,
  • check_application_structure,
  • check_inflection_file,
  • check_acyclic_graph,
  • check_package_manifest_paths,
  • check_valid_package_dependencies,
  • check_root_package_exist,
@rochlefebvre
Copy link
Contributor

Addressed in #84

shioyama pushed a commit that referenced this issue May 21, 2021
README: fix GitHub contributing URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants