Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customizing the ERB implementation #66

Closed
joshaber opened this issue Nov 11, 2020 · 0 comments · Fixed by #67
Closed

Support customizing the ERB implementation #66

joshaber opened this issue Nov 11, 2020 · 0 comments · Fixed by #67
Labels
bug Something isn't working

Comments

@joshaber
Copy link
Contributor

Description
Some gems (e.g., http://github.com/github/graphql-client) provide ERB extensions which add or modify the standard ERB syntax. To support apps which use those gems, Packwerk should allow for customizing the ERB implementation.

To Reproduce

  1. Try to run Packwerk on an app which uses http://github.com/github/graphql-client's GraphQL tags.
  2. Packwerk fails to parse the ERBs since it doesn't know how to parse the GraphQL tags

Expected Behaviour

Packwerk should provide a way to customize the ERB implementation.

Screenshots
N/A

Version Information

  • Packwerk: v1.0.1
  • Ruby: 2.6.6
@joshaber joshaber added the bug Something isn't working label Nov 11, 2020
@joshaber joshaber mentioned this issue Nov 11, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support providing a custom ERB parser class joshaber/packwerk
1 participant
@joshaber