New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid defining implicit conversion methods (to_ary, to_hash, to_int, to_str) #163

Closed

dduugg opened this issue Jul 9, 2023 · 1 comment · Fixed by #165

Contributor

dduugg commented Jul 9, 2023

Ruby supports a few methods that allow implicit type conversions.

Since Sorbet is a nominal (not structural) type system, implicit conversion is currently unsupported.

I would like to write a cop that adds violations when implicit conversion methods are defined. Would the maintainers be amenable to this?

Contributor

Morriar commented Jul 11, 2023

Yeah it seems like a good idea to have such a cop 👍

Depending on the amount of violations it creates, we may not enable it by default though.

dduugg mentioned this issue

Add new Sorbet/ImplicitConversionMethod cop #165

Merged

Morriar closed this as completed in #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment